Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): doc typo on sidebar admonition #3974

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Dec 30, 2020

Motivation

Fix #3971

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Dec 30, 2020
@slorber slorber requested a review from lex111 as a code owner December 30, 2020 10:50
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Dec 30, 2020
@netlify
Copy link

netlify bot commented Dec 30, 2020

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: 5f88e52

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5fec5b7293909c0008aaa8c2

😎 Browse the preview: https://deploy-preview-3974--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 86
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3974--docusaurus-2.netlify.app/classic/

@github-actions
Copy link

Size Change: +10 B (0%)

Total Size: 155 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.82 kB +2 B (0%)
website/build/main.********.js 111 kB +8 B (0%)
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@slorber slorber merged commit c61b49a into master Dec 30, 2020
@omry
Copy link

omry commented Dec 30, 2020

duh. of course :)

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/doc-typo-sidebar branch August 17, 2021 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs[ Sidebar note not rendering properly
4 participants