Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(v2): Cache hashed assets to dedicated folders #3998

Merged
merged 1 commit into from
Jan 5, 2021
Merged

feat(v2): Cache hashed assets to dedicated folders #3998

merged 1 commit into from
Jan 5, 2021

Conversation

kumaraditya303
Copy link
Contributor

Motivation

#3156

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Not required

Related PRs

None

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 5, 2021
@netlify
Copy link

netlify bot commented Jan 5, 2021

✔️ Deploy preview for docusaurus-2 ready!
Built without sensitive environment variables

🔨 Explore the source changes: 7d742c9

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ff41eac532c8e0007d3a9f5

😎 Browse the preview: https://deploy-preview-3998--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

Size Change: 0 B

Total Size: 154 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.81 kB 0 B
website/build/main.********.js 110 kB 0 B
website/build/styles.********.css 17.6 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Jan 5, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-3998--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Collaborator

slorber commented Jan 5, 2021

Thanks, LGTM

@slorber slorber merged commit f48d435 into facebook:master Jan 5, 2021
@slorber slorber added the pr: new feature This PR adds a new API or behavior. label Jan 5, 2021
@kumaraditya303 kumaraditya303 deleted the patch-2 branch January 5, 2021 17:18
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
This was referenced Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: new feature This PR adds a new API or behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants