Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add Nodify to showcase #4036

Merged
merged 3 commits into from
Jan 14, 2021
Merged

docs(v2): Add Nodify to showcase #4036

merged 3 commits into from
Jan 14, 2021

Conversation

miroiu
Copy link
Contributor

@miroiu miroiu commented Jan 13, 2021

Motivation

Showcasing an open source project that uses Docusaurus v2 for documentation.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

None.

Related PRs

No

@netlify
Copy link

netlify bot commented Jan 13, 2021

❌ [V1] Deploy preview failure
Built without sensitive environment variables

🔨 Explore the source changes: f715a3d

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-1/deploys/5ffff7d0bf2e860007a813ad

@facebook-github-bot
Copy link
Contributor

Hi @miroiu!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@github-actions
Copy link

github-actions bot commented Jan 13, 2021

Size Change: 0 B

Total Size: 26.8 kB

ℹ️ View Unchanged
Filename Size Change
website/build/blog/2017/12/14/introducing-docusaurus/index.html 20.8 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 5.86 kB 0 B

compressed-size-action

@netlify
Copy link

netlify bot commented Jan 13, 2021

✔️ Deploy preview for docusaurus-2 ready!

🔨 Explore the source changes: f715a3d

🔍 Inspect the deploy logs: https://app.netlify.com/sites/docusaurus-2/deploys/5ffff7d09c07a70008024615

😎 Browse the preview: https://deploy-preview-4036--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Jan 13, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 82
🟢 Accessibility 99
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4036--docusaurus-2.netlify.app/classic/

@miroiu
Copy link
Contributor Author

miroiu commented Jan 13, 2021

Hi!

I signed the CLA. Can you re-run the check, please?

Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 13, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thank you!

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Jan 14, 2021
@slorber
Copy link
Collaborator

slorber commented Jan 14, 2021

thanks :)

@slorber slorber merged commit 2402336 into facebook:master Jan 14, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants