Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): fix hreflang headers #4160

Merged
merged 1 commit into from
Feb 3, 2021
Merged

fix(v2): fix hreflang headers #4160

merged 1 commit into from
Feb 3, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Feb 2, 2021

Motivation

According to SEO tools it seems we should rather use hreflang=en for the English / default pages of the doc.
And we can actually use both x-default + en

https://www.searchviu.com/en/multiple-hreflang-tags-one-url/
https://sitebulb.com/hints/international/hreflang-annotation-also-x-default/

Have you read the Contributing Guidelines on pull requests?

yes

Test Plan

Ahrefs SEO tools

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Feb 2, 2021
@slorber slorber requested a review from lex111 as a code owner February 2, 2021 18:59
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 2, 2021
@netlify
Copy link

netlify bot commented Feb 2, 2021

[V1] Deploy preview success

Built with commit 8fc9932

https://deploy-preview-4160--docusaurus-1.netlify.app

@github-actions
Copy link

github-actions bot commented Feb 2, 2021

Size Change: +18 B (0%)

Total Size: 156 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.7 kB 0 B
website/build/assets/js/main.********.js 109 kB +14 B (0%)
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB +3 B (0%)
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB +1 B (0%)

compressed-size-action

@netlify
Copy link

netlify bot commented Feb 2, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 8fc9932

https://deploy-preview-4160--docusaurus-2.netlify.app

@slorber slorber merged commit 98453eb into master Feb 3, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
@slorber slorber deleted the slorber/fix-hreflang-i18b branch August 17, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants