-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): Extract/translate hardcoded labels from classic theme #4168
Conversation
[V1] Deploy preview success Built with commit defd176 |
Size Change: +15 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
Deploy preview for docusaurus-2 ready! Built with commit defd176 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4168--docusaurus-2.netlify.app/classic/ |
Can we provide something like a language pack with messages already translated out-of-box (French/Russian for now)? |
@lex111 I'd like to but don't really have an idea on how to do that yet 😅 if you have an idea let me know. Maybe the themes could have some kind of default translation packs or something? would probably require a new lifecycle api |
I was thinking just in the classic theme directory to add an |
Motivation
We want some theme hardcoded labels to be translated:
This is not yet an exhaustive list, some labels remain to be translated but are more complicated to handle:
Have you read the Contributing Guidelines on pull requests?
yes
Test Plan
tests + preview + i18n dogfooding