fix(v2): make locale dropdown accessible from keyboard #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview success Built with commit 89fd59f |
|
Size Change: +14 B (0%) Total Size: 156 kB ℹ️ View Unchanged
|
|
Deploy preview for docusaurus-2 ready! Built with commit 89fd59f |
|
Thanks! I'm not very familiar with a11y, is this link hash a good practice widely used? |
|
On the whole, yes, in v1 uses a similar trick, it might be worth using the button element instead, but I think the current solution will work for us. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Locale dropdown is currently not available for keyboard navigation, to fix this we need to add a
hrefattribute.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Preview.
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)