-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): Removing wrong parenthesis on image variable #4226
Conversation
[V1] Deploy preview failure Built without sensitive environment variables with commit 11db847 https://app.netlify.com/sites/docusaurus-1/deploys/602b7f3cf1a84e00081ebfd4 |
Size Change: +13 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 11db847 |
@@ -1072,7 +1072,7 @@ The ES imports syntax also works: | |||
|
|||
import myImageUrl from './assets/docusaurus-asset-example-banner.png'; | |||
|
|||
<img src={myImageUrl)} alt="My image alternative text" /> | |||
<img src={myImageUrl} alt="My image alternative text" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
Can you do that change in /website/docs/markdown-features.mdx too please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean by website/docs/guides/markdown-features/markdown-features-assets.mdx
right @slorber ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the same file in the upstream version so that it's not lost on alpha 71 when we release it ;)
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4226--docusaurus-2.netlify.app/classic/ |
Removing a wrong parenthesis on image variable.