-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(v2): fix npm/yarn command example for swizzling TypeScript theme components #4230
Conversation
Hi @YashTotale! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
[V1] Deploy preview failure Built without sensitive environment variables with commit 9b59a91 https://app.netlify.com/sites/docusaurus-1/deploys/602ca6629f06ad0007e10e80 |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 9b59a91 |
Size Change: 0 B Total Size: 158 kB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4230--docusaurus-2.netlify.app/classic/ |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
thanks was already fixed in upcoming release but not a bad idea to backport :) |
Motivation
The example was not working, because there was no extra
--
in front of--typescript
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Testing is pretty simple: run the previous example on the command line which does not work as the
--typescript
is interpreted as part of the npm command, and run the new example with an extra--
which does work as the--typescript
is interpreted as an option for the docusaurus command.