feat(v2): editUrl functions should receive md doc permalink #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[V1] Deploy preview success Built with commit ac641cc |
|
Deploy preview for docusaurus-2 ready! Built with commit ac641cc |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4232--docusaurus-2.netlify.app/classic/ |
|
Size Change: +15 B (0%) Total Size: 158 kB ℹ️ View Unchanged
|
This was referenced Mar 10, 2021
Closed
Closed
Closed
Closed
This was referenced Mar 15, 2021
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
editUrlfn should provide the user with the doc/blog permalink.This is useful for future integrations with online editing sandboxes like StackBlitz and CodeSandbox, as it allows to load the site on the correct page by passing a querystring param.
cc @EricSimons
Test Plan
tests