Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v2): remove PostCSS plugin for combine duplicated selectors #4240

Merged
merged 1 commit into from
Feb 18, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Feb 17, 2021

Motivation

Should fix #4231

At the moment, when we do not control the order of including CSS files, it is better to remove this plugin, because it raises more problems than it solved for us.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

See reproducible section in #4231.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: bug fix This PR fixes a bug in a past release. label Feb 17, 2021
@lex111 lex111 requested a review from slorber as a code owner February 17, 2021 21:16
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Feb 17, 2021
@netlify
Copy link

netlify bot commented Feb 17, 2021

[V1] Deploy preview success

Built with commit e2daf04

https://deploy-preview-4240--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Feb 17, 2021

Deploy preview for docusaurus-2 ready!

Built with commit e2daf04

https://deploy-preview-4240--docusaurus-2.netlify.app

@github-actions
Copy link

Size Change: 0 B

Total Size: 158 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 17.6 kB 0 B
website/build/assets/js/main.********.js 111 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 21.7 kB 0 B
website/build/docs/introduction/index.html 180 B 0 B
website/build/index.html 6.95 kB 0 B

compressed-size-action

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 78
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4240--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit 094b513 into master Feb 18, 2021
@lex111 lex111 deleted the lex111/iss4231 branch February 19, 2021 18:20
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom css not loaded the same way with yarn start and yarn build
3 participants