Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(v2): format last updated date using Intl #4352

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

lex111
Copy link
Contributor

@lex111 lex111 commented Mar 5, 2021

Motivation

Follow-up of #4344

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Preview.

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@lex111 lex111 added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 5, 2021
@lex111 lex111 requested a review from slorber as a code owner March 5, 2021 08:49
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 5, 2021
@netlify
Copy link

netlify bot commented Mar 5, 2021

[V1] Deploy preview success

Built with commit 28b0f6a

https://deploy-preview-4352--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Mar 5, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 28b0f6a

https://deploy-preview-4352--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

Size Change: 0 B

Total Size: 532 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.4 kB 0 B
website/build/assets/js/main.********.js 359 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.3 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.4 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Mar 5, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 77
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4352--docusaurus-2.netlify.app/classic/

@slorber
Copy link
Collaborator

slorber commented Mar 5, 2021

thanks ! :)

@slorber slorber merged commit 6be0bd4 into master Mar 5, 2021
@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 9, 2021
@slorber slorber deleted the lex111/localize-edit-date branch August 17, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants