Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(v2): [theme-classic] add Chinese translations (zh-Hant & zh-Hans) #4356

Merged
merged 1 commit into from
Mar 8, 2021
Merged

polish(v2): [theme-classic] add Chinese translations (zh-Hant & zh-Hans) #4356

merged 1 commit into from
Mar 8, 2021

Conversation

MisterFISHUP
Copy link
Contributor

Motivation

I like this project and would like to contribute by adding zh-Hant and zh-Hans translations.

zh-Hant is for traditional Chinese (eg: Taiwan, Hong Kong, Macao) and zh-Hans for simplified Chinese (eg: PRC, Singapore).

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

N/A

Related PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 6, 2021
@netlify
Copy link

netlify bot commented Mar 6, 2021

@netlify
Copy link

netlify bot commented Mar 6, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 34c1da9

https://deploy-preview-4356--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 6, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 92
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4356--docusaurus-2.netlify.app/classic/

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 8, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 8, 2021

thanks :)

Not really able to review this properly but let's merge and see if users provide feedbacks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants