Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): add rsocket.io to showcase #4360

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

viglucci
Copy link
Contributor

@viglucci viglucci commented Mar 7, 2021

Motivation

Reference rsocket.io as an example of Docusaurus v2 usage.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Run yarn run start:v2 and check that the page http://localhost:3000/showcase is rendered properly.

Related PRs

n/a

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 7, 2021
@viglucci viglucci force-pushed the feature/add-rsocket-to-showcase branch from 2c45337 to 1cf410e Compare March 7, 2021 05:48
@viglucci viglucci changed the title feat: add rsocket.io to showcase docs(v2): add rsocket.io to showcase Mar 7, 2021
@netlify
Copy link

netlify bot commented Mar 7, 2021

@netlify
Copy link

netlify bot commented Mar 7, 2021

@netlify
Copy link

netlify bot commented Mar 7, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 2c45337

https://deploy-preview-4360--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 7, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 91
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4360--docusaurus-2.netlify.app/classic/

@netlify
Copy link

netlify bot commented Mar 7, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 1cf410e

https://deploy-preview-4360--docusaurus-2.netlify.app

@lex111 lex111 merged commit 2a25124 into facebook:master Mar 7, 2021
@lex111
Copy link
Contributor

lex111 commented Mar 7, 2021

@viglucci thanks!

@lex111 lex111 added this to the v2.0.0-alpha.71 milestone Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants