Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish(v2): Add german translations #4448

Merged
merged 2 commits into from
Mar 18, 2021
Merged

polish(v2): Add german translations #4448

merged 2 commits into from
Mar 18, 2021

Conversation

miku86
Copy link
Contributor

@miku86 miku86 commented Mar 17, 2021

Hey folks,

I updated some missing translations.

Greetings
Michael

Motivation

I want to i18n my docusaurus application into German, but some theme strings are missing.
That's why I translated some missing docusaurus theme classic strings.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

I didn't change any code, just translation strings, so the existing tests should be fine.

Related PRs

None.

Hey folks,

I updated some missing translations.

Greetings
Michael
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 17, 2021
@netlify
Copy link

netlify bot commented Mar 17, 2021

[V1] Deploy preview success

Built with commit 3a194ad

https://deploy-preview-4448--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Mar 17, 2021

Deploy preview for docusaurus-2 ready!

Built with commit 3a194ad

https://deploy-preview-4448--docusaurus-2.netlify.app

@slorber slorber changed the title Add german translations polish(v2): Add german translations Mar 18, 2021
@slorber slorber added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Mar 18, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 18, 2021

Thanks :)

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 70
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4448--docusaurus-2.netlify.app/classic/

@slorber slorber merged commit 93dab24 into facebook:master Mar 18, 2021
@miku86 miku86 deleted the patch-1 branch March 20, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants