Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: json files should be linted #4462

Merged
merged 1 commit into from
Mar 18, 2021
Merged

chore: json files should be linted #4462

merged 1 commit into from
Mar 18, 2021

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Mar 18, 2021

Motivation

We don't catch json files that may be malformed and lead to errors at runtime.

For example a json typo in theme code translations lead to unability to use the Korean language:

#4461

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 18, 2021
@slorber slorber requested a review from lex111 as a code owner March 18, 2021 18:27
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 18, 2021
@netlify
Copy link

netlify bot commented Mar 18, 2021

[V1] Deploy preview success

Built with commit ee744eb

https://deploy-preview-4462--docusaurus-1.netlify.app

@netlify
Copy link

netlify bot commented Mar 18, 2021

Deploy preview for docusaurus-2 ready!

Built with commit ee744eb

https://deploy-preview-4462--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 81
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4462--docusaurus-2.netlify.app/

@github-actions
Copy link

Size Change: 0 B

Total Size: 575 kB

ℹ️ View Unchanged
Filename Size Change
website/build/assets/css/styles.********.css 87.2 kB 0 B
website/build/assets/js/main.********.js 401 kB 0 B
website/build/blog/2017/12/14/introducing-docusaurus/index.html 60.8 kB 0 B
website/build/docs/introduction/index.html 235 B 0 B
website/build/index.html 25.7 kB 0 B

compressed-size-action

@slorber slorber merged commit 5543f09 into master Mar 18, 2021
slorber added a commit that referenced this pull request Jul 22, 2021
@slorber slorber deleted the slorber/lint-json branch August 17, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants