-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: enable yarn install cache #4486
Conversation
[V1] Deploy preview failure Built without sensitive environment variables with commit 0f6f677 https://app.netlify.com/sites/docusaurus-1/deploys/605b27738cc2ec000816cf3c |
Deploy preview for docusaurus-2 ready! Built without sensitive environment variables with commit 0f6f677 |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-4486--docusaurus-2.netlify.app/ |
Hey, that's a cool idea Was just wondering if there isn't a way to remove all that verbosity? I've used this action recently and it worked great, can it be used instead? |
it can, and its your call if you think that's a good idea |
yes I think Do you want to edit this PR or we close and I do another one? |
i'm going to update this pr, do you think that we should apply this for windows machines to? |
thanks, that looks fine |
I think we can enable this on Windows too, do you see any reason not to? |
generally caching on windows gh actions seem to be slow, i will try it out |
didn't know that, is it documented or your personal experience? slower than no caching at all? |
let's merge this for now and see if we can improve windows in another PR |
Motivation
https://github.com/actions/cache/blob/main/examples.md#node---yarn
https://github.com/actions/cache/blob/main/examples.md#node---yarn-2
ci build time is now reduced per job by 30s~1min
Have you read the Contributing Guidelines on pull requests?
yes