Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enable yarn install cache #4486

Merged
merged 4 commits into from
Mar 25, 2021
Merged

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Mar 21, 2021

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 21, 2021
@armano2 armano2 changed the title test: enable yarn install cache ci: enable yarn install cache Mar 21, 2021
@netlify
Copy link

netlify bot commented Mar 21, 2021

@netlify
Copy link

netlify bot commented Mar 21, 2021

Deploy preview for docusaurus-2 ready!

Built without sensitive environment variables with commit 0f6f677

https://deploy-preview-4486--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Mar 22, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 88
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4486--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Mar 22, 2021

Hey, that's a cool idea

Was just wondering if there isn't a way to remove all that verbosity?

I've used this action recently and it worked great, can it be used instead?
https://github.com/bahmutov/npm-install

@armano2
Copy link
Contributor Author

armano2 commented Mar 24, 2021

it can, and its your call if you think that's a good idea

@slorber
Copy link
Collaborator

slorber commented Mar 24, 2021

yes I think - uses: bahmutov/npm-install@v1 would be better.

Do you want to edit this PR or we close and I do another one?

@armano2
Copy link
Contributor Author

armano2 commented Mar 24, 2021

i'm going to update this pr, do you think that we should apply this for windows machines to?

@slorber
Copy link
Collaborator

slorber commented Mar 24, 2021

thanks, that looks fine

@slorber slorber added the pr: maintenance This PR does not produce any behavior differences to end users when upgrading. label Mar 24, 2021
@slorber
Copy link
Collaborator

slorber commented Mar 24, 2021

I think we can enable this on Windows too, do you see any reason not to?

@armano2
Copy link
Contributor Author

armano2 commented Mar 24, 2021

generally caching on windows gh actions seem to be slow, i will try it out

@slorber
Copy link
Collaborator

slorber commented Mar 24, 2021

didn't know that, is it documented or your personal experience? slower than no caching at all?

@slorber
Copy link
Collaborator

slorber commented Mar 25, 2021

let's merge this for now and see if we can improve windows in another PR

@slorber slorber merged commit 88a48a0 into facebook:master Mar 25, 2021
@armano2 armano2 deleted the test/workflows-caching branch November 3, 2021 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: maintenance This PR does not produce any behavior differences to end users when upgrading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants