Fix broken link to site-config #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoelMarcey
suggested changes
Feb 16, 2018
There was a problem hiding this comment.
@justinmusgrove Hi. Thanks for catching this. It is wrong, but I think the fix is to use the right file name instead of moving to .html.
It should be api-site-config.md#optional-fields.
I forgot the api- :)
|
@JoelMarcey - this has been updated... |
JoelMarcey
approved these changes
Feb 17, 2018
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
On https://docusaurus.io/docs/en/custom-pages.html the $wrapPagesHTML site config link is referencing https://docusaurus.io/docs/en/site-config.md#optional-fields. It appears that it should reference https://docusaurus.io/docs/en/site-config.html#optional-fields
Test Plan
Visual - replaced "md" with "html"
https://docusaurus.io/docs/en/site-config.md#optional-fields
https://docusaurus.io/docs/en/site-config.html#optional-fields
Related PRs
b1ecd98