Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(v2): Add Hostman to deployment doc #4668

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Conversation

alena-ko
Copy link
Contributor

Motivation

(Write your motivation here.)

Have you read the Contributing Guidelines on pull requests?

(Write your answer here.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work. Bonus points for screenshots and videos!)

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot
Copy link
Contributor

Hi @alena-ko!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Apr 22, 2021

[V2]

Built with commit cd3abdc

https://deploy-preview-4668--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Apr 22, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 73
🟢 Accessibility 96
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-4668--docusaurus-2.netlify.app/

@slorber
Copy link
Collaborator

slorber commented Apr 22, 2021

Thanks

Signing the CLA is a legal requirement, I technically can't merge the PR until the bot report it's done

@slorber slorber changed the title Update deployment.mdx docs(v2): Add Hostman to deployment doc Apr 22, 2021
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Apr 22, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 23, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@netlify
Copy link

netlify bot commented Apr 26, 2021

[V1]

Built with commit cd3abdc

https://deploy-preview-4668--docusaurus-1.netlify.app

@slorber slorber merged commit ad74342 into facebook:master Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants