Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing i18n support in side nav breadcrumb #482

Merged
merged 1 commit into from
Mar 4, 2018

Conversation

cheercroaker
Copy link
Contributor

Hello, I have noticed another (as in yesterday's PR #477) place where internationalization support seemed to be missing and submit this PR to hopefully help fixing gaps.

Motivation

When in a configuration where screen width is limited (e.g. small smartphone), a breadcrumb appears to help the user know where s·he is.
The breadcrumb simply was not taking selected language into account—in the case where localization was enabled and an additional language added.
This PR is here to localize the breadcrumb label, leveraging a local existing function for this purpose.

Have you read the Contributing Guidelines on pull requests?

Yes; the file went through prettier, which should conform to expected format and please the CI checker.
Manual tests were done.

Test Plan

  1. Have a project with localization enabled, additional language supported and a content leading to multiple sections in the side nav bar

  2. Reduce the size of the browser to the minimum to simulate a small device with limited width: the side navigation bar should appear, with the breadcrumb

  3. Change language (by selecting it through the upper-right drop down menu) and navigate using the breadcrumb: all breadcrumb labels should take the selected language into account

Related PRs

PR #477 is in the same vein.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 1, 2018
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good catch! Thank you!

@JoelMarcey JoelMarcey merged commit 4553afd into facebook:master Mar 4, 2018
@cheercroaker cheercroaker deleted the i18n-SideNavBreadcrumb branch March 4, 2018 10:24
@cheercroaker
Copy link
Contributor Author

You're welcome, thank you for having created and made possible to contribute to this great project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants