Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add <doctype HTML> to HTML pages #566

Merged
merged 2 commits into from
Apr 15, 2018
Merged

Add <doctype HTML> to HTML pages #566

merged 2 commits into from
Apr 15, 2018

Conversation

yangshun
Copy link
Contributor

Motivation

All modern HTML pages should be served with <doctype HTML> in order to trigger standards mode in browsers.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  1. Loaded the website locally (that's how I found out we needed to serve main.css with the proper content-type.
  2. Built the website into static files and loaded the page via a local Python webserver.

Related PRs

Based on #382 by @Tonours.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 15, 2018
JoelMarcey
JoelMarcey approved these changes Apr 15, 2018
View reviewed changes
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3 this.

@JoelMarcey
Copy link
Contributor

@yangshun Would we close #382 as well when this merges? And we would also close #383 as well.

Definitely merge this when you are ready.

@yangshun
Copy link
Contributor Author

yangshun commented Apr 15, 2018 •
edited
Loading

Oh yes, I'll close #382 and #383 when this is merged. I'll merge this then! 😄

@yangshun yangshun closed this Apr 15, 2018
@yangshun yangshun reopened this Apr 15, 2018
@yangshun yangshun merged commit 946e2ce into facebook:master Apr 15, 2018
@yangshun yangshun deleted the static branch April 15, 2018 22:50
This was referenced Apr 15, 2018
Closed
Closed
@yangshun yangshun mentioned this pull request Apr 25, 2018
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 25, 2021
Open
@snyk-bot snyk-bot mentioned this pull request Nov 5, 2022
Open
@NikolayS NikolayS mentioned this pull request Dec 25, 2022
Open
@NikolayS NikolayS mentioned this pull request Jun 22, 2023
Open
@SNYKabbott SNYKabbott mentioned this pull request Jun 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelMarcey JoelMarcey JoelMarcey approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangshun @JoelMarcey @facebook-github-bot