Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Realized that the CSS of the site was using
device-width
media queries, which is deprecated. Use ofdevice-width
is not encouraged because it uses the hardware width rather than the viewport width.This Stack Overflow thread explains well why it's a bad idea:
In fact, the site is already suffering from this bug, for example, for the mobile web version of the installation page, the "Edit" button is shown even though it's not supposed to, going by the media query:
I replaced all
device-width
with thewidth
variants and removed redundantmin-width
s. Having themin-width
breakpoint does not make much sense because there are is no CSS written to handle the widths smaller than the ones the CSS currently has.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Loaded the page on Chrome Devtools Pixel 2 resolution and navigated all the pages. No visible issues found.
Related PRs
None