-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(content-docs): displayed_sidebar front matter #5782
Merged
Merged
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
c737f2f
feat(content-docs): displayed_sidebar front matter & displayThisSideb…
Josh-Cena 9b21b50
Minor refactor
Josh-Cena efbfd85
Fixes
Josh-Cena d6bc965
Fix
Josh-Cena 33924bb
Fix tests
Josh-Cena 6fd3033
Fix snapshot
Josh-Cena 3b980dd
Guard against undefined
Josh-Cena fa2735e
Final test fix
Josh-Cena bbc0599
Remove displayThisSidebar
Josh-Cena 5c815e6
Bring back ref type
Josh-Cena 8c99e59
Reorder docs
Josh-Cena aa0c8dd
Fix tests
Josh-Cena 1ffab96
Update sidebar.md
Josh-Cena 954d05f
Merge branch 'main' into display-sidebar
Josh-Cena 7b61563
Merge branch 'main' into display-sidebar
Josh-Cena 43b77b9
Merge branch 'main' into display-sidebar (I know things don't work)
Josh-Cena 36d2b5a
WIP
Josh-Cena f1dad0a
Merge branch 'main' into display-sidebar
Josh-Cena 1912115
Merge branch 'main' into display-sidebar
Josh-Cena 78e37f9
revert doc changes
Josh-Cena 3dba1e4
revert doc changes
Josh-Cena 32c7711
this works?
Josh-Cena a6a2f7e
fix
Josh-Cena 1421f0b
fix test
Josh-Cena 2117679
dogfood
Josh-Cena 54ac4ec
fix type
Josh-Cena aa6240e
fix
Josh-Cena File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
displayed_sidebar: anotherSidebar | ||
--- | ||
|
||
# Doc with another sidebar | ||
|
||
My link appears in a sidebar, but I want to display another sidebar... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
--- | ||
displayed_sidebar: null | ||
--- | ||
|
||
# Doc without sidebar | ||
|
||
My link appears in a sidebar, but I don't want to display that... |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
# Just a dummy page |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
break either implicit binding?
I'm not native but that sounds weird to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Break the forward binding, or backward binding 😄 I think it makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, seems good enough, we can improve later if anyone complains :D