Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add twitterImage to siteConfig options #580

Merged
merged 2 commits into from
Apr 18, 2018
Merged

Add twitterImage to siteConfig options #580

merged 2 commits into from
Apr 18, 2018

Conversation

JoelMarcey
Copy link
Contributor

Motivation

Fixes #578

og:Image should work according to https://developer.twitter.com/en/docs/tweets/optimize-with-cards/guides/getting-started, but it looks like it is not.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

local

Related PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 17, 2018
yangshun
yangshun approved these changes Apr 18, 2018
View reviewed changes
Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! It would be helpful to add in ogImage and twitterImage to the example siteConfig.js as well.

@JoelMarcey
Copy link
Contributor Author

@yangshun Thanks. I will add those in a separate commit.

@JoelMarcey JoelMarcey merged commit e738bbd into facebook:master Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yangshun yangshun yangshun approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoelMarcey @yangshun @facebook-github-bot