-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: onBrokenMarkdownAssets config option to catch bad asset paths without failing #5909
Conversation
✔️ [V2] 🔨 Explore the source changes: 2f45d8b 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f3b28e64a4160008b6431c 😎 Browse the preview: https://deploy-preview-5909--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5909--docusaurus-2.netlify.app/ |
Size Change: +31 B (0%) Total Size: 755 kB
ℹ️ View Unchanged
|
Not sure what should happen if the path doesn't exist though: should it still be |
If you convert it to Not sure how to easily test for this without a site fixture or E2E test |
Closing. To be resolved after #6370 |
Motivation
Resolve #3992. This config option is used for both links and images as they are treated in pretty much the same fashion.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
TODO