Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add PREFS website to showcase #5984

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Conversation

Patitotective
Copy link
Contributor

@Patitotective Patitotective commented Nov 21, 2021

Motivation

Help to improve docusaurus showcase section (and by the way promote PREFS).

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Just added a new element to Users list in website/src/data/users.tsx and prefs.png to website/src/data/showcase.
website/src/data/showcase/prefs.png
(See https://github.com/facebook/docusaurus/pull/5984/files for the changed files).

@netlify
Copy link

netlify bot commented Nov 21, 2021

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: c53dfa5

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/619c17d5016c08000760263c

😎 Browse the preview: https://deploy-preview-5984--docusaurus-2.netlify.app

@github-actions
Copy link

github-actions bot commented Nov 21, 2021

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 85
🟢 Accessibility 98
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 95

Lighthouse ran on https://deploy-preview-5984--docusaurus-2.netlify.app/

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, your screenshot doesn't fill the entire container though:

image

Could you submit a taller image? It's better to overflow than underflow.

Also, interesting choice of choosing Docusuarus. I think Sphinx is more trending in the Python ecosystem

@Patitotective
Copy link
Contributor Author

Patitotective commented Nov 22, 2021

@Josh-Cena
Just updated showcase image, let me know if it works (if it doesn't please tell me which aspect ratio it should be)


Also, interesting choice of choosing Docusuarus. I think Sphinx is more trending in the Python ecosystem

Well, if you have seen Sphinx docs, they're so... ugly when Docusaurus is so pretty and of course, it supports versioning the exact way I need it, previously I was using readthedocs.io and the versions were Git tags so I wasn't able to modify a specific version (fix typos) with Docusaurus I have all I want.

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, good choice of Docusaurus then 👍

Thanks again

@Josh-Cena Josh-Cena changed the title Added PREFS website to showcase docs: add PREFS website to showcase Nov 22, 2021
@Josh-Cena Josh-Cena added the pr: documentation This PR works on the website or other text documents in the repo. label Nov 22, 2021
@Josh-Cena Josh-Cena merged commit 713d145 into facebook:main Nov 22, 2021
slorber pushed a commit that referenced this pull request Nov 24, 2021
* Added PREFS website in showcase

* Added prefs.png preview image for PREFS website (showcase)

* Delete Screenshot 2021-11-21 at 15-40-04 Home PREFS.png

* Uploaded PREFS showcase image with wrong filename.

Changed PREFS showcase image file to `prefs.png`

* Delete prefs.png

* New taller showcase image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants