Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore 'custom_edit_url' #604

Merged
merged 1 commit into from
Apr 25, 2018
Merged

Do not ignore 'custom_edit_url' #604

merged 1 commit into from
Apr 25, 2018

Conversation

stevenzeck
Copy link
Contributor

Motivation

Receiving header field 'custom_edit_url' is not supported in terminal

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

  • Add custom_edit_url to any `.md' file
  • Start server and verify you receive the not supported message
  • Add custom_edit_url into readMetadata.js
  • Start server again and verify that that message is no longer reported in terminal
  • Regress

Related PRs

None

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@stevenzeck
Copy link
Contributor Author

stevenzeck commented Apr 25, 2018

I have signed the CLA now. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 25, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@yangshun yangshun merged commit df6f6df into facebook:master Apr 25, 2018
@yangshun
Copy link
Contributor

Many thanks! 🎉

@stevenzeck
Copy link
Contributor Author

@yangshun it looks like with this original commit ad5b8b9 it completely ignores headings if they're not supported, shouldn't it be throwing an error since it's a breaking change?

@yangshun
Copy link
Contributor

@szeck87 It's not a breaking change if only supported fields were used. In this case, it was our bug that we didn't update the supported header fields with the full set. I'll do an audit on them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants