Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code block appearance #609

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Improve code block appearance #609

merged 1 commit into from
Apr 27, 2018

Conversation

yangshun
Copy link
Contributor

Motivation

Improve appearance of code blocks.

  1. Give more padding to code blocks
  2. Remove left-border - it looks more professional
  3. Use another highlight theme that goes better with the theme colors of the site

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before

screen shot 2018-04-26 at 10 12 53 pm

After

screen shot 2018-04-26 at 10 13 00 pm

Related PRs

NA

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 27, 2018
JoelMarcey
JoelMarcey approved these changes Apr 27, 2018
View reviewed changes
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, I am so happy about your redesigns 😄

@JoelMarcey JoelMarcey merged commit 327d044 into facebook:master Apr 27, 2018
@yangshun yangshun deleted the code-block-appearance branch April 27, 2018 21:10
@Qdigital Qdigital mentioned this pull request Apr 25, 2023
Open
@NikolayS NikolayS mentioned this pull request Jan 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoelMarcey JoelMarcey JoelMarcey approved these changes

Assignees
No one assigned
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangshun @JoelMarcey @facebook-github-bot