Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar revamp #617

Merged
merged 3 commits into from
Apr 29, 2018
Merged

Sidebar revamp #617

merged 3 commits into from
Apr 29, 2018

Conversation

yangshun
Copy link
Contributor

Motivation

Make the sidebar look cleaner (less Chrome, more whitespace). I feel that this is nicer and closer to the other documentation sites. Sites that I referenced:

I plan to clean up the CSS and overall theme in subsequent PRs.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Before

screen shot 2018-04-28 at 1 04 21 pm

After

screen shot 2018-04-28 at 12 04 47 pm

Mobile

localhost_3000_docs_en_next_navigation html pixel 2

Related PRs

NA.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Apr 28, 2018
Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you and the screenshots 👍

@JoelMarcey JoelMarcey merged commit 812f2be into facebook:master Apr 29, 2018
@balloob
Copy link
Contributor

balloob commented Apr 29, 2018

Beautiful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants