Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating peerDependency fields for yarn berry #6498

Merged
merged 1 commit into from
Jan 29, 2022

Conversation

vidarc
Copy link
Contributor

@vidarc vidarc commented Jan 29, 2022

Motivation

Updating peerDependency fields to resolve all the warnings that the latest version of yarn outputs.

Have you read the Contributing Guidelines on pull requests?

👍

Test Plan

The following addition to my .yarnrc.yml file resolves all the warnings.

packageExtensions:
  "@docusaurus/mdx-loader@*":
    peerDependencies:
      "@babel/core": "*"
  "@docusaurus/plugin-content-blog@*":
    peerDependencies:
      "@babel/core": "*"
  "@docusaurus/plugin-content-docs@*":
    peerDependencies:
      "@babel/core": "*"
  "@docusaurus/plugin-content-pages@*":
    peerDependencies:
      "@babel/core": "*"
  "@docusaurus/plugin-debug@*":
    peerDependencies:
      "@babel/core": "*"
      webpack: "*"
  "@docusaurus/plugin-google-analytics@*":
    peerDependencies:
      "@babel/core": "*"
      webpack: "*"
  "@docusaurus/plugin-google-gtag@*":
    peerDependencies:
      "@babel/core": "*"
      webpack: "*"
  "@docusaurus/plugin-sitemap@*":
    peerDependencies:
      "@babel/core": "*"
      webpack: "*"
  "@docusaurus/preset-classic@*":
    peerDependencies:
      "@babel/core": "*"
      prism-react-renderer: "*"
      webpack: "*"
  "@docusaurus/theme-classic@*":
    peerDependencies:
      "@babel/core": "*"
      webpack: "*"
  "@docusaurus/theme-common@*":
    peerDependencies:
      "@babel/core": "*"
  "@docusaurus/theme-search-algolia@*":
    peerDependencies:
      "@babel/core": "*"
      prism-react-renderer: "*"
      webpack: "*"
  "@docusaurus/utils-validation@*":
    peerDependencies:
      "@babel/core": "*"
      webpack: "*"

Related PRs

(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jan 29, 2022
@netlify
Copy link

netlify bot commented Jan 29, 2022

✔️ [V2]
Built without sensitive environment variables

🔨 Explore the source changes: 2af9aff

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f49f46daaf3d0007ca0ad4

😎 Browse the preview: https://deploy-preview-6498--docusaurus-2.netlify.app

@github-actions
Copy link

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟠 Performance 74
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 100
🟢 PWA 92

Lighthouse ran on https://deploy-preview-6498--docusaurus-2.netlify.app/

@@ -51,6 +51,6 @@
"@babel/core": "^7.0.0",
"react": "*",
"react-dom": "*",
"webpack": "5.x"
"webpack": "^5.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.x is the same as ^5.0.0 as I understand?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure. Was thinking better to standardize the version style. That was the only one using an x

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sure

Copy link
Collaborator

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Josh-Cena Josh-Cena merged commit d45f96f into facebook:main Jan 29, 2022
@Josh-Cena Josh-Cena added the pr: polish This PR adds a very minor behavior improvement that users will enjoy. label Jan 29, 2022
@Josh-Cena Josh-Cena mentioned this pull request Feb 5, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: polish This PR adds a very minor behavior improvement that users will enjoy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants