-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updating peerDependency fields for yarn berry #6498
Conversation
✔️ [V2] 🔨 Explore the source changes: 2af9aff 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61f49f46daaf3d0007ca0ad4 😎 Browse the preview: https://deploy-preview-6498--docusaurus-2.netlify.app |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6498--docusaurus-2.netlify.app/ |
@@ -51,6 +51,6 @@ | |||
"@babel/core": "^7.0.0", | |||
"react": "*", | |||
"react-dom": "*", | |||
"webpack": "5.x" | |||
"webpack": "^5.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5.x
is the same as ^5.0.0
as I understand?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure. Was thinking better to standardize the version style. That was the only one using an x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Motivation
Updating peerDependency fields to resolve all the warnings that the latest version of yarn outputs.
Have you read the Contributing Guidelines on pull requests?
👍
Test Plan
The following addition to my
.yarnrc.yml
file resolves all the warnings.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)