Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package-lock.json #669

Merged
merged 1 commit into from
May 17, 2018
Merged

Conversation

JoelMarcey
Copy link
Contributor

Motivation

Get our package-lock.json current.

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

None

Related PRs

Maybe #663

@JoelMarcey JoelMarcey requested a review from yangshun May 17, 2018 00:26
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 17, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 97b68e8

https://deploy-preview-669--docusaurus-preview.netlify.com

@amyrlam amyrlam mentioned this pull request May 17, 2018
@amyrlam
Copy link
Contributor

amyrlam commented May 17, 2018

This solves my issue in #663, thank you!

I'm not sure if we should commit both the package-lock.json and the yarn.lock? I was reading this StackOverflow post about it...

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow never knew package-lock.json made that much of a difference.

@yangshun yangshun merged commit c8965be into facebook:master May 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants