-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove outdated restriction regarding docs nesting #746
Conversation
Deploy preview for docusaurus-preview ready! Built with commit 88387e3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this 😄
@endiliey On a side note, I have the following questions:
|
I just found out a typo
Edit: @JoelMarcey mentioned he wanted to dogfood https://github.com/facebook/Docusaurus/tree/master/admin |
How about writing a script to migrate the current and versioned docs to nested?
I can try doing that tomorrow 👍 But do let me know if you want to do it instead |
@yangshun appreciate it if you could help me on that. I'll be out of reach from my laptop in the next few hours for a week. No wifi & laptop at hospital 😢. Relying on mobile data :( |
No problem, I'll take care of it. Rest well! Take care 😄 |
Thanks 😂 . On a side note, actually we have to basically replace all markdown linking Example:
to
Edit: I'm also not sure if our translation at Crowdin will reset to 0 if we change the docs file name |
I thought moving Or #whynotboth 😄
@yangshun I don't think this works for |
That's a good point @endiliey. We will need to take into account the affect on our translations. I will need to ask @ericnakagawa or the folks at Crowdin on the affect of a file move. But we can still start with |
Motivation
@endiliey shipped a feature to allow doc nesting. This PR removes the outdated restriction in siteConfig regarding docs nesting.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
NA. Doc change.
Related PRs
#705