fix(create-docusaurus): add missing dependencies to templates

[merceyz]

Pre-flight checklist

• I have read the Contributing Guidelines on pull requests.
• If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
• If this is a new API or substantial change: the PR has an accompanying issue (closes Yarn PNP and TypeScript doesn't compile out of the box #6157) and the maintainers have approved on my working plan.

Motivation

Resolve the type checking errors in the templates by adding undeclared dependencies.

Motivations for the changes made:

• JS and TS templates must depend on @docusaurus/types since they try to
  import from it in docusaurus.config.js.

• The TS template must depend on @docusaurus/theme-classic and @types/node
  since @tsconfig/docusaurus specifies that they need to be loaded.

• The TS template must depend on @types/react since it imports from react
  and also needs to provide it to @docusaurus/theme-classic for its types.

• The @types/react resolutions entry is needed because other @types
  packages depend on @types/react@* which causes duplicated/incompatible types.

Test Plan

e2e test should pass.

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

#7521
#6157 (comment)

[netlify]

✅ [V2]

Built without sensitive environment variables

Name	Link
🔨 Latest commit	d10a3d9
🔍 Latest deploy log	https://app.netlify.com/sites/docusaurus-2/deploys/62ac64200d214500095e16f5
😎 Deploy Preview	https://deploy-preview-7539--docusaurus-2.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[github-actions]

⚡️ Lighthouse report for the deploy preview of this PR

URL	Performance	Accessibility	Best Practices	SEO	PWA	Report
/	🟠 71	🟢 100	🟢 100	🟢 100	🟢 90	Report
/docs/installation	🟠 80	🟢 99	🟢 100	🟢 100	🟢 90	Report

[Josh-Cena]

Thanks! I'm glad we can fix this issue.

However, I wonder if it's necessary to actually add @docusaurus/theme-classic to the dependencies? To an average user it may be confusing why this is needed, because this dependency is kind of hidden in the shareable tsconfig. (And we have a lot of "below average" users that don't use PnP and don't understand how it works!)

[Josh-Cena]

We don't necessarily want to let users use @types/react@17. Does it work if they install @types/react@18 instead?

[merceyz]

Most likely but the template depends on react@^17.0.2 so the types should match that.

[Josh-Cena]

Err, it's also speaking for ourselves. We do use @types/react@18 in our code base (for other strictness it brings) so having duplicates doesn't seem ideal for us. But I see the reason for most others.

[merceyz]

I wonder if it's necessary to actually add @docusaurus/theme-classic to the dependencies? To an average user it may be confusing why this is needed, because this dependency is kind of hidden in the shareable tsconfig

It can be "hidden" by having @docusaurus/preset-classic expose it and a .d.ts file in the template that references it instead of the types config in tsconfig.json (see how Next.js does this) but as it stands right now it's required.

(And we have a lot of "below average" users that don't use PnP and don't understand how it works!)

While that's fair this is an issue with node_modules as well.

[Josh-Cena]

I see... I'll think about in the coming days about what we shall do. I think we should re-export all types from preset-classic.