Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add pincman site to showcase #7718

Merged
merged 4 commits into from
Jul 6, 2022
Merged

docs: add pincman site to showcase #7718

merged 4 commits into from
Jul 6, 2022

Conversation

pincman
Copy link
Contributor

@pincman pincman commented Jul 2, 2022

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Add my site to showcase

Test Plan

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

@facebook-github-bot
Copy link
Contributor

Hi @pincman!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@netlify
Copy link

netlify bot commented Jul 2, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 6385b8c
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/62c2930c11719e000827b436
😎 Deploy Preview https://deploy-preview-7718--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jul 2, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 73 🟢 100 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 86 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena
Copy link
Collaborator

@pincman I have a question: what editor is it that adds a .history directory? Could you add it to .gitignore?

@pincman
Copy link
Contributor Author

pincman commented Jul 2, 2022

@Josh-Cena I think I forgot to add this, I will resubmit

@pincman
Copy link
Contributor Author

pincman commented Jul 2, 2022

@Josh-Cena I have deleted .history in the repository

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 2, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@Josh-Cena Josh-Cena changed the title add pincman site docs: add pincman site to showcase Jul 4, 2022
@slorber
Copy link
Collaborator

slorber commented Jul 6, 2022

LGTM thanks 👍

@slorber
Copy link
Collaborator

slorber commented Jul 6, 2022

Should we merge the .history gitignore? Still not clear to me what's the purpose of it

@Josh-Cena
Copy link
Collaborator

It's some IDE that adds it. Not a problem to be part of the PR.

@slorber slorber merged commit f224d3c into facebook:main Jul 6, 2022
slorber pushed a commit that referenced this pull request Jul 14, 2022
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: showcase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants