Move custom translation strings to its own file

[JoelMarcey]

Motivation

Allowing custom and overriding translation strings in en.json caused us to not delete en.json like we used to do and thus would not allow updates to header to be reflected any longer.

Fixes #713

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Local testing

Related PRs

#158
#710

[JoelMarcey]

This is still a work in progress. Got some more testing and changes I want to do, but in my initial testing, this seems to fix the problem.

[docusaurus-bot]

Deploy preview for docusaurus-preview ready!

Built with commit ab1ca99

https://deploy-preview-775--docusaurus-preview.netlify.com

[docusaurus-bot]

Deploy preview for docusaurus-preview ready!

Built with commit efc6f06

https://deploy-preview-775--docusaurus-preview.netlify.com

[endiliey]

1. Do we want to let user to define their own path to the custom translation string or must it be hardcoded /website/data/custom-translation-strings.json ?
2. Update the docs 😀

[JoelMarcey]

Do we want to let user to define their own path to the custom translation string or must it be hardcoded /website/data/custom-translation-strings.json ?

Given that we already have a data directory for custom information (e.g. site users), I think defaulting to that directory is reasonable. If we get pushback for a custom siteConfig.js option, we can always add it in the future -- but trying to avoid adding more to siteConfig.js unless there is a big want/need.

Seem reasonable?

Update the docs 😀

Absolutely! Just making sure this is the right direction. 😄

[endiliey]

Seems reasonable for me. Let's not bloat siteConfig.js 🤣

LGTM. Seems to be in the right direction

[JoelMarcey]

@endiliey Docs - https://deploy-preview-775--docusaurus-preview.netlify.com/docs/en/next/translation#custom-translation-strings

I am just going to show a test plan, then I will remove the [RFC] from this and get it officially reviewed and merged.

[rickyvetter]

Looks awesome! Thanks for fixing :)

[vaibhavsingh97]

@JoelMarcey This looks awesome to me 👍

[JoelMarcey]

Added a test plan. This should be ready for review and merging.