chore(theme-translations): complete ko translations #7762
Conversation
Josh-Cena
changed the title
Josh-Cena
added
the
pr: polish
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Pinging @revi @winterlood @HyunseungLee-Travis @koko8829 (Really appreciate it btw—you guys are making ko one of the most well-maintained locales, both here and on Crowdin.) |
|
I added some screenshots to help the peer checkings 😌
|
| "theme.SearchModal.footer.closeText": "로 종료", | ||
| "theme.SearchModal.footer.navigateDownKeyAriaLabel": "화살표 아래 키", | ||
| "theme.SearchModal.footer.navigateText": "로 이동", | ||
| "theme.SearchModal.footer.navigateUpKeyAriaLabel": "화살표 위 키", | ||
| "theme.SearchModal.footer.searchByText": "Search by", |
There was a problem hiding this comment.
I assume this is fine?
I did translate it for zh btw. I understand the order of words may be a bit weird in Asian languages. I basically translated it as "Search provider".
There was a problem hiding this comment.
This actually makes more sense to me, from the keyboard glyph on the modal.
If these translations will only be used for the below screenshot, it suits well.
If it’s used somewhere else, then I might need to review it.
There was a problem hiding this comment.
No, "Search by algolia" is only in this one place AFAICT. It's fine if you don't want to translate it. I did translate it for zh:
There was a problem hiding this comment.
Wait, do you mean “Search By”? Well then it’s whatsoever. I think it wouldn’t really matter if that remains in English. I didn’t think of any better alternatives.
There was a problem hiding this comment.
Yeah, it's awkward in Chinese as well. I wouldn't mind since it's not informative anyway.
There was a problem hiding this comment.
Maybe we could do 검색 제공.
There was a problem hiding this comment.
For the context, I misunderstood your first comment. I have added translation keys for Search by.
There was a problem hiding this comment.
It is fine either way, translated or untranslated.
|
Translation LGTM. (Code-Review) +1. |
|
Oh BTW, @koko8829 has already submitted translations for these on Crowdin haha: https://crowdin.com/translate/docusaurus-v2/642/en-ko?filter=basic&value=0 I can't read Hangul but I assume you've compared the two versions? (Can be viewed on https://docusaurus.io/ko/) |
|
@Josh-Cena, I prefer my translations, but I would love to discuss it with @koko8829. |
I like your translation. |
|
@koko8829 So you would confirm this PR is good to merge? Would one of you update the translations on Crowdin, so when this gets merged, the production build will have the new translations? |
Translation LGTM. I will update the translations on Crowdin. |
|
Thanks, please let me know when you're done so we can merge this and do a production build. |
The update has been completed. |
|
Nice, let's merge then. Thanks again @anaclumos @revi @koko8829! |
Pre-flight checklist
Motivation
This improves Korean Translations for Algolia Search.
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs