-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Netlify branch deploys should only deploy default locale "en" #7788
Merged
slorber
merged 1 commit into
docusaurus-v2
from
slorber/v2/netlify-deploy-branches-no-translations
Jul 15, 2022
Merged
chore: Netlify branch deploys should only deploy default locale "en" #7788
slorber
merged 1 commit into
docusaurus-v2
from
slorber/v2/netlify-deploy-branches-no-translations
Jul 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: internal
This PR does not touch production code, or is not meaningful enough to be in the changelog.
label
Jul 15, 2022
slorber
commented
Jul 15, 2022
@@ -23,7 +23,8 @@ | |||
"build:blogOnly": "cross-env yarn build --config=docusaurus.config-blog-only.js", | |||
"build:fast": "cross-env BUILD_FAST=true yarn build --locale en", | |||
"netlify:build:production": "yarn docusaurus write-translations && yarn netlify:crowdin:delay && yarn netlify:crowdin:uploadSources && yarn netlify:crowdin:downloadTranslations && yarn build && yarn test:css-order", | |||
"netlify:build:deployPreview": "yarn docusaurus write-translations --locale fr --messagePrefix '(fr) ' && yarn build && yarn test:css-order", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed because we used to deploy "fr" in deploy previews, but not anymore
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
Size Change: 0 B Total Size: 805 kB ℹ️ View Unchanged
|
This was referenced Jan 9, 2024
This was referenced Apr 29, 2024
This was referenced May 13, 2024
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
Signed Facebook CLA
pr: internal
This PR does not touch production code, or is not meaningful enough to be in the changelog.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: Netlify branch deploys should only deploy default locale "en"
Follow-up of #7787
We don't want branch deploys like
docusaurus-v2
to be slow and do anything with CrowdinUsers reading v2 doc will read it from the prod website deployment (always deployed from
main
branch)