Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show scrollbar only when sidebar is too long #800

Merged
merged 1 commit into from
Jun 25, 2018
Merged

Show scrollbar only when sidebar is too long #800

merged 1 commit into from
Jun 25, 2018

Conversation

yangshun
Copy link
Contributor

Motivation

Fixes #793

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Normal height page

screen shot 2018-06-24 at 8 15 26 pm

Short height page

screen shot 2018-06-24 at 8 15 30 pm

Related PRs

#757

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jun 25, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit e6c1110

https://deploy-preview-800--docusaurus-preview.netlify.com

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@endiliey endiliey merged commit e4b9b98 into facebook:master Jun 25, 2018
@yangshun yangshun deleted the scrollbar branch June 27, 2018 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants