Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): fix blog post social card #8042

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Sep 2, 2022

It should show 2.1 instead of 2.0 😅

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Sep 2, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Sep 2, 2022
@Josh-Cena
Copy link
Collaborator

Can we enable auto-merge?

@netlify
Copy link

netlify bot commented Sep 2, 2022

[V2]

Name Link
🔨 Latest commit c0d8caa
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6311f96d1506bb0009b3b7c8
😎 Deploy Preview https://deploy-preview-8042--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@slorber slorber merged commit 29703da into main Sep 2, 2022
@slorber slorber deleted the slorber/fix-blog-post-social-image branch September 2, 2022 12:43
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟢 98 🟢 100 🟢 100 🟠 80 Report
/docs/installation 🟠 79 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber
Copy link
Collaborator Author

slorber commented Sep 2, 2022

Can we enable auto-merge?

You mean once a PR is at least approved?

I still think it's useful to review the deploy preview in many cases, our tests do not capture 100% of problems

@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Size Change: 0 B

Total Size: 813 kB

ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 52.1 kB
website/build/assets/css/styles.********.css 111 kB
website/build/assets/js/main.********.js 609 kB
website/build/index.html 40.8 kB

compressed-size-action

@Josh-Cena
Copy link
Collaborator

I don't know if auto merging requires PR approval. But for trivial changes like this, auto merging sounds fine.

slorber added a commit that referenced this pull request Sep 7, 2022
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants