Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): mobile scroll on homepage announcement #8193

Merged
merged 1 commit into from
Oct 12, 2022
Merged

fix(website): mobile scroll on homepage announcement #8193

merged 1 commit into from
Oct 12, 2022

Conversation

maliMirkec
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 8, 2022

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit e1d9738
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/6341dd89cfc5250008ded316
😎 Deploy Preview https://deploy-preview-8193--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Oct 8, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 60 🟢 98 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 72 🟢 100 🟢 100 🟢 100 🟢 90 Report

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Oct 8, 2022
@slorber
Copy link
Collaborator

slorber commented Oct 12, 2022

Thanks 👍

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Oct 12, 2022
@slorber slorber changed the title Fixing mobile scroll on the homepage fix(website): fixing mobile scroll on the homepage Docusaurus 2 announcement Oct 12, 2022
@Josh-Cena Josh-Cena changed the title fix(website): fixing mobile scroll on the homepage Docusaurus 2 announcement fix(website): fixing mobile scroll on the homepage announcement Oct 12, 2022
@Josh-Cena Josh-Cena changed the title fix(website): fixing mobile scroll on the homepage announcement fix(website): mobile scroll on homepage announcement Oct 12, 2022
@slorber
Copy link
Collaborator

slorber commented Oct 12, 2022

For context, as far as I understand this fixes a horizontal scroll on small viewports around 300-350px width.

We still have it for smaller widths but it's an improvement and likely good enough for now

CleanShot 2022-10-12 at 18 23 22@2x

@slorber slorber merged commit 84e6dd2 into facebook:main Oct 12, 2022
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants