Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs,theme): auto-generated category index should not display unlisted content #8319

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

slorber
Copy link
Collaborator

@slorber slorber commented Nov 10, 2022

Motivation

Fix #8301

The auto-generated category index should not present content with unlisted: true frontmatter in production mode.

Test Plan

Unit tests

Dogfood: SIMULATE_PRODUCTION_VISIBILITY=true yarn start:website

Test links

Related issues/PRs

Missing edge case from #8004

@slorber slorber added the pr: bug fix This PR fixes a bug in a past release. label Nov 10, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Nov 10, 2022
@netlify
Copy link

netlify bot commented Nov 10, 2022

[V2]

Name Link
🔨 Latest commit fadadee
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/636d2fa638ed0400085de13d
😎 Deploy Preview https://deploy-preview-8319--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Nov 10, 2022

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 91 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 77 🟢 100 🟢 100 🟢 100 🟢 90 Report

@slorber slorber added the to backport This PR is planned to be backported to a stable version of Docusaurus label Nov 10, 2022
@github-actions
Copy link

Size Change: +141 B (0%)

Total Size: 885 kB

Filename Size Change
website/build/assets/js/main.********.js 662 kB +141 B (0%)
ℹ️ View Unchanged
Filename Size
website/.docusaurus/globalData.json 70.2 kB
website/build/assets/css/styles.********.css 112 kB
website/build/index.html 40.9 kB

compressed-size-action

@slorber slorber merged commit d8c72fb into main Nov 10, 2022
@slorber slorber deleted the slorber/fix-unlisted-autogenerated-index branch November 10, 2022 17:31
@slorber slorber removed the to backport This PR is planned to be backported to a stable version of Docusaurus label Jan 26, 2023
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: bug fix This PR fixes a bug in a past release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unlisted doc page accessible from auto generated category index
2 participants