Skip to content

Add support for alt text of logo for navbar & footer in translations builds #8551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Add support for alt text of logo for navbar & footer in translations builds #8551

wants to merge 6 commits into from

Conversation

Mysterious-Dev
Copy link
Contributor

@Mysterious-Dev Mysterious-Dev commented Jan 15, 2023

Pre-flight checklist

Motivation

This PR can allow more control for translations by the addition of footer & navbar alt text for logo.

It's a detail but that can be usefull to translate the alt text for footer Logo of docusaurus website (https://github.com/facebook/docusaurus/blob/main/website/docusaurus.config.js#L622) to be more consistent.

Test Plan

Translations tests have been updated for the package docusaurus-theme-classic ^^.

Test links

Deploy preview: https://deploy-preview-8551--docusaurus-2.netlify.app/

@netlify
Copy link

netlify bot commented Jan 15, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit 3a909c0
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/63c3dbcc1d72bb000825f3bd
😎 Deploy Preview https://deploy-preview-8551--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 65 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 80 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Mysterious-Dev Mysterious-Dev changed the title Add support for navbar & footer alt logo in translations builds Add support for alt text of logo for navbar & footer in translations builds Jan 15, 2023
@Mysterious-Dev Mysterious-Dev marked this pull request as draft January 18, 2023 10:03
@Mysterious-Dev Mysterious-Dev deleted the translations_one branch January 18, 2023 10:07
@slorber
Copy link
Collaborator

slorber commented Jan 18, 2023

curious to know why you decided to close it? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants