-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add documentation regarding usage of nested docs + git ignore .idea #860
Conversation
Deploy preview for docusaurus-preview ready! Built with commit 3304fdb |
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Thanks for the PR @steevehook
I will let @yangshun or @JoelMarcey see the wordings one more time before merging this |
My pleasure contributing ❤️ @endiliey. Was nice to have a look in the project source, and sorry for the rework. Guess I'll need to familiarize myself with the project to know better where's what. If any other contribution needed I'll be around |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
Just curious why we are updating the 1.2.0 version of the doc too?
@JoelMarcey because this is supposed to be documented for >= 1.2.0 when subdirectories were implemented. (my fault 😢) |
Ok - fair enough. That may be the first time we retroactively added docs for previous versions. |
Motivation
Glad to contribute to such a nice project 🥇
Test Plan
Added changes to
api-doc-markdown
then created a new version in order to be able to testModerator Edit:
Close #855