Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation regarding usage of nested docs + git ignore .idea #860

Merged
merged 4 commits into from
Jul 19, 2018
Merged

add documentation regarding usage of nested docs + git ignore .idea #860

merged 4 commits into from
Jul 19, 2018

Conversation

steevehook
Copy link
Contributor

@steevehook steevehook commented Jul 18, 2018

Motivation

Glad to contribute to such a nice project 🥇

Test Plan

Added changes to api-doc-markdown then created a new version in order to be able to test

Moderator Edit:

Close #855

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Jul 18, 2018

Deploy preview for docusaurus-preview ready!

Built with commit 3304fdb

https://deploy-preview-860--docusaurus-preview.netlify.com

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Jul 18, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@endiliey
Copy link
Contributor

endiliey commented Jul 18, 2018

Thanks for the PR @steevehook

  1. There is no need to cut version 1.3.3 for this. All changes in docs will be reflected in next. So it is available for example at localhost:3000/docs/en/next/navigation
  2. I've moved it to navigation document instead and simplified the wording

I will let @yangshun or @JoelMarcey see the wordings one more time before merging this

@steevehook
Copy link
Contributor Author

My pleasure contributing ❤️ @endiliey. Was nice to have a look in the project source, and sorry for the rework. Guess I'll need to familiarize myself with the project to know better where's what. If any other contribution needed I'll be around

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

Just curious why we are updating the 1.2.0 version of the doc too?

@endiliey
Copy link
Contributor

endiliey commented Jul 18, 2018

@JoelMarcey because this is supposed to be documented for >= 1.2.0 when subdirectories were implemented. (my fault 😢)

@JoelMarcey
Copy link
Contributor

Ok - fair enough. That may be the first time we retroactively added docs for previous versions.

@endiliey endiliey merged commit 22f3a85 into facebook:master Jul 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants