Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): improve color toggle when using dark navbar #8615

Merged
merged 16 commits into from
Feb 23, 2023
Merged

fix(theme): improve color toggle when using dark navbar #8615

Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
ca7f1d1
color toggle contrast issue removed
dewanshDT Feb 1, 2023
33c925c
fixed
dewanshDT Feb 1, 2023
71f0f3d
style dark
dewanshDT Feb 2, 2023
ad8eb26
workaround
dewanshDT Feb 2, 2023
ce3b703
priority
dewanshDT Feb 2, 2023
3d35a13
fix
dewanshDT Feb 2, 2023
23f86fd
final
dewanshDT Feb 2, 2023
47b117e
final
dewanshDT Feb 2, 2023
14c14f7
changes
dewanshDT Feb 2, 2023
51d8535
changes
dewanshDT Feb 2, 2023
1d36297
Merge branch 'dewansh-color-toggle-contrast' of https://github.com/de…
dewanshDT Feb 2, 2023
1a6733c
undo
dewanshDT Feb 2, 2023
7640010
data-style
dewanshDT Feb 2, 2023
1d83d3e
final
dewanshDT Feb 2, 2023
c2c6c89
refactor solution to avoid coupling comp to navbar usecase
slorber Feb 17, 2023
9d68678
remove useless line
slorber Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/docusaurus-theme-classic/src/theme/ColorModeToggle/styles.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@
background: var(--ifm-color-emphasis-200);
}

.navbar--dark .toggleButton:hover {
background: var(--ifm-color-gray-800);
}
dewanshDT marked this conversation as resolved.
Show resolved Hide resolved

[data-theme='light'] .darkToggleIcon,
[data-theme='dark'] .lightToggleIcon {
display: none;
Expand Down