-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Make command work on both Linux and Windows #8704
Conversation
Change command to backslash so it works on both Linux and Windows machines. Trying to run the command as is results in a syntax error on Windows.
Correction: the command |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
⚡️ Lighthouse report for the deploy preview of this PR
|
We might want to add a small text describing what the code snippet does too. Just a thought. |
We could use tabs if you can find another command that do the same for windows? |
Yep, I was thinking that. I'll add that in. |
@slorber my PR LGTM now. The commands now show up in tabs and the Windows commands work on Windows. |
Related to #8703 |
One note on the We might have to separate the translation workflow out into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks a bit complex just to copy files 😅
What about using a nodejs package that works the same on both platforms?
npx cpy-cli 'docs/**' 'i18n/fr/docusaurus-plugin-content-docs/current'
@slorber I agree... |
mkdir -p i18n\fr\docusaurus-plugin-content-docs\current | ||
cp -r docs\** i18n\fr\docusaurus-plugin-content-docs\current |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this command is working fine on windows as long as you use powershell
instead of cmd
tested in
PowerShell 7.3.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with Sebastién that a single, cross-platform command would be best. See here: #8704 (review)
Hey @Zenahr, is there anyway I can help with this? |
closing until someone comes up with a simple PR |
@slorber I believe this issue is closed for a simple PR, should I work on it? |
Not sure what you mean @0xSaksham you can submit a new PR taking into consideration my existing review on this PR |
Change command to backslash so it works on both Linux and Windows machines. Trying to run the command as is results in a syntax error on Windows.
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs
#8703