Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update suggestion for OSS meta projects #8804

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

antonk52
Copy link
Contributor

Pre-flight checklist

Motivation

The facebook template is outdated and is currently discouraged to be used for internal projects. At Meta we have an internal boilerplate that nicely integrates with our tooling and should be preferred to "facebook" template.

Test Plan

N/A

Test links

Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/

Related issues/PRs

N/A

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Mar 22, 2023
@netlify
Copy link

netlify bot commented Mar 22, 2023

[V2]

Built without sensitive environment variables

Name Link
🔨 Latest commit ea57724
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/641aed7b93968600085dd3b2
😎 Deploy Preview https://deploy-preview-8804--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟢 94 🟢 97 🟢 100 🟢 100 🟢 90 Report
/docs/installation 🟠 83 🟢 100 🟢 100 🟢 100 🟢 90 Report

@Josh-Cena Josh-Cena requested a review from zpao March 22, 2023 12:31
@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label Mar 22, 2023
@slorber
Copy link
Collaborator

slorber commented Mar 22, 2023

Thanks @antonk52

Should we also delete the facebook template from the possible choices? or we wait a bit?

@slorber slorber merged commit 9c6b79b into facebook:main Mar 22, 2023
@antonk52
Copy link
Contributor Author

@slorber thanks for merging.

Good point. It is safe to remove as it has been discouraged from using internally for some time now.

@slorber
Copy link
Collaborator

slorber commented Mar 23, 2023

Thanks, noted to remove it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants