Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installation doc #888

Merged
merged 2 commits into from
Aug 5, 2018
Merged

Conversation

willingc
Copy link
Contributor

@willingc willingc commented Aug 5, 2018

Motivation

This PR clarifies a few installation points that we ran into when installing Docusaurus for https://docs.nteract.io

Contributing back to a project that we find very useful and hope it helps future users.

Have you read the Contributing Guidelines on pull requests?

Yes

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

docusaurus-bot commented Aug 5, 2018

Deploy preview for docusaurus-preview ready!

Built with commit 41a81da

https://deploy-preview-888--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 5, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willingc I agree with your proposed changes. Thanks for improving this! 😄

@yangshun yangshun merged commit 29e71eb into facebook:master Aug 5, 2018
@willingc
Copy link
Contributor Author

willingc commented Aug 5, 2018

Thanks for the fast review @yangshun. 😄

@willingc willingc deleted the update-install branch August 5, 2018 22:50
@yangshun
Copy link
Contributor

yangshun commented Aug 5, 2018

@willingc Do let us know which of your projects you are using Docusaurus for by adding it to our Users page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants