Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update link in md code blocks section #8975

Merged
merged 2 commits into from
May 15, 2023
Merged

Conversation

rbarbazz
Copy link
Contributor

@rbarbazz rbarbazz commented May 14, 2023

Updated the link for default bundled languages

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

The link to the base set of bundled languages was broken. I got the new link from the prism-react-renderer README page.
It's a permalink though, maybe we want to use the path instead (i.e.: https://github.com/FormidableLabs/prism-react-renderer/blob/master/packages/generate-prism-languages/index.ts#L9-L24)?

Test Plan

N/A

Test links

Old link: https://docusaurus.io/docs/markdown-features/code-blocks#supported-languages
Deploy preview: https://deploy-preview-8975--docusaurus-2.netlify.app/docs/markdown-features/code-blocks/#supported-languages

Related issues/PRs

#8976

Link for default bundled languages
@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label May 14, 2023
@netlify
Copy link

netlify bot commented May 14, 2023

[V2]

Name Link
🔨 Latest commit 2de2d1a
🔍 Latest deploy log https://app.netlify.com/sites/docusaurus-2/deploys/646224990d22430008b1c57d
😎 Deploy Preview https://deploy-preview-8975--docusaurus-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented May 14, 2023

⚡️ Lighthouse report for the deploy preview of this PR

URL Performance Accessibility Best Practices SEO PWA Report
/ 🟠 72 🟢 97 🟢 92 🟢 100 🟠 89 Report
/docs/installation 🟠 86 🟢 100 🟢 92 🟢 100 🟠 89 Report

@slorber slorber added the pr: documentation This PR works on the website or other text documents in the repo. label May 15, 2023
@slorber slorber merged commit 8b10934 into facebook:main May 15, 2023
@rbarbazz rbarbazz deleted the patch-1 branch May 15, 2023 15:12
This was referenced Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA pr: documentation This PR works on the website or other text documents in the repo.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants