Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed css/main.css route #904

Merged
merged 1 commit into from
Aug 22, 2018
Merged

Conversation

mikalai-s
Copy link
Contributor

Motivation

When using docusaurus-start a server treats any request that ends with main.css as one to serve css/main.css. That could break some custom assets in static dir that also have main.css name.

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

  1. css/main.css is served:
    • run docusarus-start
    • ensured a home page loads css/main.css
  2. css/main.css and custom main.css are served:
    • added api/main.css to static dir
    • updated siteConfig.js with separateCss: ["static/api"]
    • run docusarus-start
    • ensured both css/main.css and api/main.css are served

Related PRs

None.

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 63a4805

https://deploy-preview-904--docusaurus-preview.netlify.com

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 14, 2018
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@endiliey endiliey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@endiliey endiliey merged commit 6004fef into facebook:master Aug 22, 2018
@mikalai-s mikalai-s deleted the fix-main-css-route branch August 24, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants