Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix console error when onPageNav !== 'separate' #909

Merged
merged 1 commit into from
Aug 21, 2018

Conversation

miralemd
Copy link
Contributor

Motivation

Fixes #908

Have you read the Contributing Guidelines on pull requests?

Yes.

Test Plan

Run site - no errors :)

Related PRs

None.

@facebook-github-bot facebook-github-bot added the CLA Signed Signed Facebook CLA label Aug 21, 2018
@docusaurus-bot
Copy link
Contributor

Deploy preview for docusaurus-preview ready!

Built with commit 51d52f8

https://deploy-preview-909--docusaurus-preview.netlify.com

@yangshun
Copy link
Contributor

There's only one accepted value for onPageNav which is 'separate' so other values are not expected to work. But indeed we should handle errors better. Thanks for the PR!

Copy link
Contributor

@yangshun yangshun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@yangshun yangshun merged commit 8900548 into facebook:master Aug 21, 2018
@miralemd
Copy link
Contributor Author

@yangshun I get that values other than 'separate' are not handled - the issue here is that onPageNav is an optional setting but is assumed to exist, so the error will be thrown for all projects that don't set a value for onPageNav.

@yangshun
Copy link
Contributor

Right, good catch! Many thanks for taking the time to submit a PR 😄

@miralemd miralemd deleted the fix-console-error branch August 22, 2018 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants