-
-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(theme-translations): translation for Uzbek (uz) #9209
Conversation
Hi @Zukhrik! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
✅ [V2]Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
⚡️ Lighthouse report for the deploy preview of this PR
|
packages/docusaurus-theme-translations/locales/uz/theme-search-algolia.json
Show resolved
Hide resolved
I wonder if we should have a threshold to limit the number of languages we have. I understand that every language is potentially useful to some users, but we need to weigh between out-of-the-box usefulness and the extra install size this brings to everyone, including the 99.9% of users that don't need it. Plus there's maintenance issues, quality control, etc. @slorber WDYT? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I can't be sure the translations are good but I notice errors on the plural forms.
Please read this part to understand how to handle plurals:
#3526
Uzbek only has 2 cardinal plural forms, according to
- this page: https://www.unicode.org/cldr/cldr-aux/charts/34/supplemental/language_plural_rules.html
- the browser Intl API data
Thus, your pluralized translations should only contain 2 parts and not 3.
Also the placeholders should not be translated
packages/docusaurus-theme-translations/locales/uz/theme-common.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/uz/theme-search-algolia.json
Outdated
Show resolved
Hide resolved
packages/docusaurus-theme-translations/locales/uz/theme-common.json
Outdated
Show resolved
Hide resolved
This probably does not increase install size that much IMHO. There are lower hanging fruits to consider, like inlining our dependencies like Next.js does, which as a much more significant impact. I don't think it's time to optimize this part yet, and the maintenance remains reasonable so far. |
Pre-flight checklist
Motivation
Test Plan
Test links
Deploy preview: https://deploy-preview-_____--docusaurus-2.netlify.app/
Related issues/PRs